Re: [PATCH] last-fm: add extra and mega large thumbnails

["Juan A." Suárez Romero <jasuarez igalia com>]

On Mon, 2011-03-07 at 10:33 +0000, lionel g landwerlin linux intel com
wrote:
> From: Lionel Landwerlin <lionel g landwerlin linux intel com>
> 
> Signed-off-by: Lionel Landwerlin <lionel g landwerlin linux intel com>
> ---

> -  image = xml_get_image (content, LASTFM_XML_COVER_MEDIUM);
> +  image = xml_get_image (content, LASTFM_XML_COVER_MEGA);
> +  if (image) {
> +    relkeys = grl_related_keys_new_with_keys (GRL_METADATA_KEY_THUMBNAIL, image,
> +                                              NULL);
> +    grl_data_add_related_keys (GRL_DATA (rs->media), relkeys);
> +    g_free (image);
> +  }

Is there any reason to choose the MEGA size as the first value?

Note that those applications that does not handle multi-valued keys will
only see this MEGA.

Previously I had choosed the medium because of that: it is neither the
smallest, nor the biggest.

I wonder if MEGA is too much big for those applications that only wants
to show a small thumbnail. I don't have a strong opinion about this, but
I would like to hear other opinions too.


	J.A.