Re: [PATCH 07/11] bookmarks: do not expose the bookmarking time of a media

[Iago Toral <itoral igalia com>]

Not sure about this: creation date for a bookmarks plugin could 
perfectly refer to the moment the bookmark (not the bookmarked media) 
was created. And can indeed provide useful information to users when 
they are interested in knowing when they created that bookmark, the 
usefulness of this is pretty similar to the usefulness of the 
modification date in the file system plugin for example (maybe 
modification date is more appropriate for this too, not sure either).

I would be more in favour of exposing the data than hiding it (if this 
is indeed a mistake I rather make this one than hiding useful 
information that we have).

Iago

On Wed, 22 Jun 2011 19:13:52 +0200, Guillaume Emont 
<guijemont igalia com> wrote:
> This date/time does not fit well in our current set of keys, and it 
> doesn't
> seem to be useful for anyone. It is still kept in the database, and 
> could be
> exposed again in the future with a specific metadata key if it is 
> needed.
> ---
>  src/media/bookmarks/grl-bookmarks.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/src/media/bookmarks/grl-bookmarks.c
> b/src/media/bookmarks/grl-bookmarks.c
> index ced21e8..6764073 100644
> --- a/src/media/bookmarks/grl-bookmarks.c
> +++ b/src/media/bookmarks/grl-bookmarks.c
> @@ -323,7 +323,6 @@ build_media_from_stmt (GrlMedia *content,
> sqlite3_stmt *sql_stmt)
>    gchar *title;
>    gchar *url;
>    gchar *desc;
> -  gchar *date;
>    gchar *mime;
>    guint type;
>    guint childcount;
> @@ -336,7 +335,6 @@ build_media_from_stmt (GrlMedia *content,
> sqlite3_stmt *sql_stmt)
>    title = (gchar *) sqlite3_column_text (sql_stmt, BOOKMARK_TITLE);
>    url = (gchar *) sqlite3_column_text (sql_stmt, BOOKMARK_URL);
>    desc = (gchar *) sqlite3_column_text (sql_stmt, BOOKMARK_DESC);
> -  date = (gchar *) sqlite3_column_text (sql_stmt, BOOKMARK_DATE);
>    mime = (gchar *) sqlite3_column_text (sql_stmt, BOOKMARK_MIME);
>    type = (guint) sqlite3_column_int (sql_stmt, BOOKMARK_TYPE);
>    childcount = (guint) sqlite3_column_int (sql_stmt, 
> BOOKMARK_CHILDCOUNT);
> @@ -361,9 +359,6 @@ build_media_from_stmt (GrlMedia *content,
> sqlite3_stmt *sql_stmt)
>    if (desc) {
>      grl_media_set_description (media, desc);
>    }
> -  if (date) {
> -    grl_media_set_date (media, date);
> -  }
>
>    if (type == BOOKMARK_TYPE_CATEGORY) {
>      grl_media_box_set_childcount (GRL_MEDIA_BOX (media), 
> childcount);
> @@ -693,7 +688,6 @@ grl_bookmarks_source_supported_keys
> (GrlMetadataSource *source)
>                                        GRL_METADATA_KEY_URL,
>                                        GRL_METADATA_KEY_CHILDCOUNT,
>                                        GRL_METADATA_KEY_DESCRIPTION,
> -                                      GRL_METADATA_KEY_DATE,
>                                        NULL);
>    }
>    return keys;