Re: [PATCH] core: introduce grilo operations

["Juan A. Suarez Romero" <jasuarez igalia com>]

On Fri, 2011-06-17 at 11:04 +0200, Juan A. Suarez Romero wrote:
> > 
> > Juan or Guillaume, could you have a look at it? 
> 
> Sure.
> 

(Modified) patch pushed!

Thanks for it! Makes things easier to develop.

I did some changes in the patch, though.

- I've removed the deprecated functions, instead of keeping them
deprecated. As this patch will appear in a new series 0.2.x, which is
not compatible with the previous 0.1.x release, I've removed all
deprecated functions to start from scratch.

- The same way, I removed the "Since: 0.1.16" comment. Usually, this
comments are added in the release process, to be sure that it matches
the right version.

- I've renamed grl_operation_set_callbacks() to
grl_operation_set_private_data(). At first, I found a bit weird having
the grl_operation_get_private_data(), but not the
grl_operation_set_private_data(). Then, I realized that _set_callbacks()
was doing that, before setting the callbacks. So I did the rename
because I feel it is more natural.

- Fixed a leak: in the _set_callbacks() (now _set_private_data()), you
set at GDestroyNotify function that is never invoked. So I've fixed it.


All these changes were commented with Lionel, and he agreed with them.

	J.A.