Re: [PATCH 1/3] local-metadata: added a new local source

[Guillaume Emont <gemont igalia com>]

On 31/01/2011 09:14, Iago Toral wrote:
>
> Hi Guillaume,
>
> a few comments:
>
> - the patches did not build for me, you need to add the gthread-2.0
> dependency to your test, otherwise it fails to link.
> - we cannot use copyrighted images for the tests, please provide new
> ones.
>
> Some other comments below:
(...)
> +error:
>> +    {
>> +      GError *new_error;
>> +      if (error)
>> +        new_error = g_error_new (GRL_CORE_ERROR,
>> GRL_CORE_ERROR_RESOLVE_FAILED,
>> +                                 "Got error: %s", error->message);
>> +      else
>> +        new_error = g_error_new (GRL_CORE_ERROR,
>> GRL_CORE_ERROR_RESOLVE_FAILED,
>> +                                 "Could not find a thumbnail for %s",
>> +                                 g_file_get_path (file));
>
> Not finding the thumbnail should not raise an error, it is a normal
> situation. At least other plugins do not raise an error if they cannot
> find the metadata they have been requested.
Do you think we should silently ignore that, or should we GRL_WARNING()?

Thanks for your comments,

Guij