Re: [PATCH 1/3] local-metadata: added a new local source

[Guillaume Emont <gemont igalia com>]

On 27/01/2011 09:05, Iago Toral wrote:
>
> Shouldn't we emit an error here? client is using the API with invalid
> URI or invalid key...
>
>
> Same here, we should emit an error.
Not sure where we should draw the line between "no result" and "error".
But this would be worth defining clearly, ideally in the documentation
of MetadataSource. For now, Juan seems to say other plugins behave in
the same way, so I'd be tempted to leave it like this.
>
>
>> diff --git a/src/local-metadata/grl-local-metadata.xml
>> b/src/local-metadata/grl-local-metadata.xml
>> new file mode 100644
>> index 0000000..11e4d32
>> --- /dev/null
>> +++ b/src/local-metadata/grl-local-metadata.xml
>> @@ -0,0 +1,9 @@
>> +<plugin>
>> +  <info>
>> +    <name>Fake Metadata Provider</name>
>> +    <description>A plugin for faking metadata resolution</description>
>> +    <author>Igalia S.L.</author>
>> +    <license>LGPL</license>
>> +    <site>http://www.igalia.com</site>
>> +  </info>
>> +</plugin>
>
> I guess you copied this from the fake metadata plugin, needs proper
> editing :)
Woops. Will resend patches with this modified
>
> BTW, let's not forget to fix the issues in core that prevent testing
> this through grilo-test-ui, I think that should be high priority.
>
> Iago
>
>
> _______________________________________________
> grilo-list mailing list
> grilo-list gnome org
> http://mail.gnome.org/mailman/listinfo/grilo-list
>