Re: [PATCH 1/3] local-metadata: added a new local source



On Thu, 2011-01-27 at 08:05 +0000, Iago Toral wrote:
>  Shouldn't we emit an error here? client is using the API with
> invalid 
>  URI or invalid key...
> 

I've been checking other metadata sources, and the errors about trying
to resolve unsupported keys, or if dependencies were not fulfilled were
silently discarded.

I think the point was that if preconditions were not satisfied then it
was not considered an error, just moving the media to next level
(invoking callback with media untouched). Only when preconditions were
satisfied, but source can't resolve them (because for instance it can't
connect to backend) an error were emitted.

Maybe we should emit an error for these cases too. Not sure, really. In
these cases, I think adding a GRL_CORE_ERROR_RESOLVE_UNSUPPORTED and
GRL_CORE_ERROR_RESOLVE_REQ_FAILED would be worth.

	J.A.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]