Re: [PATCH] configure.ac: if --host is selected, use the $host-pkg-config instead of hard coded pkg-config (mostly for cross compiling)

[Víctor M. Jáquez L. <vjaquez igalia com>]

On Thu, Jan 20, 2011 at 09:58:04AM +0000, Lionel Landwerlin wrote:
> On Wed, 2011-01-19 at 21:19 +0000, Fabien Lebaillif - Delamare wrote:
> ---
> >  configure.ac |   11 ++++++++---
> >  1 files changed, 8 insertions(+), 3 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index fe82bd9..ebcdc9f 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -20,6 +20,11 @@ AM_CONFIG_HEADER(src/config.h)
> >  AC_PROG_CC
> >  AC_PROG_INSTALL
> >  
> > +PKG_CONFIG="pkg-config"
> > +if test -n "$host" ; then
> > +	PKG_CONFIG=$host-$PKG_CONFIG
> > +fi
> > +
> > 
> Why not removing this part and let the called of configure to override
> the PKG_CONFIG value when needed ?
> I'm not sure even Openembedded renames its pkg-config for target as
> $host-$PKG_CONFIG.

Also scratchbox, buildroot and maybe more. I guess it should be read from the
environment variables instead.

vmjl


> 
> Otherwise using $PKG_CONFIG is good.
> 
> Regards,
> 
> --
> Lionel Landwerlin
> 
> _______________________________________________
> grilo-list mailing list
> grilo-list gnome org
> http://mail.gnome.org/mailman/listinfo/grilo-list
>