Re: [PATCH 1/5] local-metadata: udpated to may_resolve() API

["Juan A." Suárez Romero <jasuarez igalia com>]

On Thu, 2011-02-24 at 13:57 +0100, Juan A. Suárez Romero wrote:
> On Tue, 2011-02-22 at 16:32 +0100, Guillaume Emont wrote:
> > +  if (media && grl_data_key_is_known (GRL_DATA (media),
> > GRL_METADATA_KEY_URL))
> > +    return has_compatible_media_url (media);
> >   
> 
> 
> media should be always non-NULL.
> 
> Either I would check it with g_return_val_if_fail(), or do the check in
> core, before invoking the source function.
> 


Please, forget my comment.

Didn't realize that invoking may_resolve() with NULL media we get the
same result as key_depends(), so I think it's worth to have this
behaviour.


	J.A.