Re: [PATCH 1/5] local-metadata: udpated to may_resolve() API
- From: "Juan A." Suárez Romero <jasuarez igalia com>
 
- To: grilo-list gnome org
 
- Subject: Re: [PATCH 1/5] local-metadata: udpated to may_resolve() API
 
- Date: Thu, 24 Feb 2011 13:55:08 +0100
 
On Tue, 2011-02-22 at 16:32 +0100, Guillaume Emont wrote:
>  
> -  if (key_id == GRL_METADATA_KEY_THUMBNAIL)
> -    return deps;
> +  if (missing_keys)
> +    *missing_keys = grl_metadata_key_list_new (GRL_METADATA_KEY_URL,
> NULL);
>   
I think it would be better to use g_list_append() than
grl_metadata_key_list_new()
Thus, we could invoke may_resolve() using the same missing_keys list for
all keys, collecting all the missing keys in the same list.
	J.A.
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]