Re: [PATCH 1/2] core: Allow NULL text search()
- From: "Juan A." Suárez Romero <jasuarez igalia com>
- To: grilo-list gnome org
- Subject: Re: [PATCH 1/2] core: Allow NULL text search()
- Date: Thu, 03 Feb 2011 09:51:30 +0100
On Thu, 2011-02-03 at 07:15 +0000, Iago Toral wrote:
> If @text is NULL then no text filter will be applied, and thus, no
> media items from @source will be filtered. If @source does not
> NULL-text search operations it should notify the client by setting
> error parameter in @callback.
Wouldn't it better to say "[...] NULL-text search operations it will
notify the client [...]" ?
Documentation is explaining what the function does, not what it should
] [Thread Prev