Re: [PATCH 4/5] core: Add default =?UTF-8?Q?notify=5Fchange=5Fsto?= =?UTF-8?Q?p=28=29=20behaviour?=




Is this really needed? Also, if we make this feature available only if plugins implement both start and stop, I guess there is no reason to do this.

On Tue, 1 Feb 2011 09:07:45 +0100, "Juan A. Suarez Romero" <jasuarez igalia com> wrote:
In case sources does not re-implement notify_change_stop(), just stop signal
emission.

Signed-off-by: Juan A. Suarez Romero <jasuarez igalia com>
---
 src/grl-media-source.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/src/grl-media-source.c b/src/grl-media-source.c
index 1db85d6..4402c8c 100644
--- a/src/grl-media-source.c
+++ b/src/grl-media-source.c
@@ -2572,6 +2572,11 @@ void grl_media_source_notify_change_stop
(GrlMediaSource *source)

   if (source_class->notify_change_stop) {
     source_class->notify_change_stop (source);
+  } else {
+    /* Just stop signal emission */
+    g_signal_stop_emission (source,
+                            registry_signals[SIG_CONTENT_CHANGED],
+                            0);
   }
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]