Re: Caps and Options update

[Guillaume Emont <gemont igalia com>]

Thanks for all your comments, I have pushed a new version on gitorious
that takes them in account.

Here is how I see the next steps, with the aim of integration into trunk:
 0. Fix issues you guys might raise on the latest version
 1. Remove pagination and flags from caps.
 2. (optional) make _set_value() and _get_value() private for both
options and caps.
 3. Modify code in metadata source and media source to use use caps and
options.
 4. Modify at least one plugin to make sure the model works
 5. Modify all plugins to handle the new model
 6. Test everything
 7. (optional) merge all changes, as from this point on, we should
normally not need to break API/ABI to add filtering and sorting support
 8. and 9. Add filtering and sorting support, not sure what order makes
more sense. Filtering would probably be faster to implement since Juan
has already spent quite some time studying the issue.

Any comments on that? (especially the optional steps). Does that look
like a sensible way of doing that?

Guij


On 04/04/2011 20:14, Guillaume Emont wrote:
> Following the discussions we've had, I've advanced the development of
> GrlCaps and GrlOperationOptions.
> I've pushed the current state of things to my gitorious repository [1]
> The stuff is in src/grl-caps.{h,c} and src/grl-operation-options.{h,c}.
> I have also added some helper tools to handle GValues in
> grl-value-helper.{h,c}
> 
> I'd be happy to have some feedback on that before I start integrating it
> into grl-metadata-source.c.
> 
> Some notes on it though:
>  - I have put caps and pagination in the caps, even though they might
> not be needed here (because we're likely to want these to be mandatory).
> This might change in the future, and is like that mainly to illustrate
> how caps and options interact.
>  - the _set_value() methods are inconsistent in the way they take
> ownership of their parameters. I plan to change that, probably to always
> copy @value, since taking ownership of it is assuming it was created
> using grl_g_value_new(), which might not always be true.
>  - for the options and caps that are defined, I think we should have
> default values. I'm still hesitating on whether to put that in
> initialisation or in getters.
> 
> Cheers,
> 
> Guij
> 
> [1]
> https://www.gitorious.org/~guijemont/grilo/guijemont-sandbox/trees/caps_and_options
> _______________________________________________
> grilo-list mailing list
> grilo-list gnome org
> http://mail.gnome.org/mailman/listinfo/grilo-list
>