Re: [PATCH] core: Allow grouping all changed medias in "content-changed" signal

[Iago Toral <itoral igalia com>]

A few minor comments below...

On Fri,  1 Apr 2011 13:05:25 +0200, "Juan A. Suarez Romero" 
<jasuarez igalia com> wrote:
(...)
> --- a/src/grl-media-source.c
> +++ b/src/grl-media-source.c
> @@ -227,20 +227,26 @@ grl_media_source_class_init
> (GrlMediaSourceClass *media_source_class)
>    /**
>     * GrlMediaSource::content-changed:
>     * @source: source that has changed
> -   * @media: the media that changed or one of its ancestors
> +   * @changed_medias: pointer to #GList with the medias that changed
> or one of
> +   * their ancestors
>     * @change_type: the kind of change that ocurred
>     * @location_unknown: @TRUE if the change happened in @media
> itself or in one
>     * of its direct children (when @media is a #GrlMediaBox). @FALSE
> otherwise
>     *
> -   * Signals that the content in the source has changed. Usually 
> @media is a
> -   * #GrlBox, meaning that the content of that box has changed. if
> -   * @location_unknown is @TRUE it means the source cannot establish
> where the
> -   * change happened: could be either in the box, in any child, or 
> in any
> -   * other descendant of the box in the hierarchy.
> +   * Signals that the content in the source has changed.
> @changed_medias is the
> +   * list of elements that have been changed. Usually this medias
                                                         ^^^^ these
> are #GrlBox,

are of type #GrlBox.

> +   * meaning that the content of that box has changed.
> +   *
> +   * I @location_unknown is @TRUE it means the source cannot
> establish where the
> +   * change happened: could be either in the box, in any child, or
> in any other
> +   * descendant of the box in the hierarchy.
> +   *
> +   * Both @change_type and @location_unknown are applied to all
> elements in the
> +   * list.
>     *
>     * For the cases where the source can only signal that a change
> happened, but
> -   * not where, it would use the root box (@NULL id) and set
> location_unknown as
> -   * to @TRUE.
> +   * not where, it would use a list with the the root box (@NULL id) 
> and set
> +   * location_unknown as to @TRUE.
                         ^^ Remove this
>     *
>     * Since: 0.1.9
>     */

Iago