Re: [PATCH] vala: Improved metadata

[Víctor M. Jáquez L. <vjaquez igalia com>]

NAK

On Tue, Sep 28, 2010 at 12:12:04AM +0200, Simón Pena wrote:
> Added metadata information for PluginRegistry, MediaPlugin, MediaSource
> MetadataSource and GrlData. Organized metadata file in sections to improve
> readability.
> ---
>  bindings/vala/grilo-0.1.metadata |   51 +++++++++++++++++++++++++++++++++++++-
>  1 files changed, 50 insertions(+), 1 deletions(-)
> 
> diff --git a/bindings/vala/grilo-0.1.metadata b/bindings/vala/grilo-0.1.metadata
> index 8db1d04..e8d00bd 100644
> --- a/bindings/vala/grilo-0.1.metadata
> +++ b/bindings/vala/grilo-0.1.metadata
> @@ -1,11 +1,60 @@
> +# Grilo library
>  Grl cprefix="Grl" lower_case_cprefix="grl_" cheader_filename="grilo.h"
> -grl_plugin_registry_get_sources is_array="1" no_array_length="1"
> +
> +# GrlPluginRegistry
> +grl_plugin_registry_get_metadata_keys type_arguments="unowned KeyID" transfer_ownership="1"
> +grl_plugin_registry_get_sources type_arguments="unowned MediaPlugin" transfer_ownership="1"
> +grl_plugin_registry_get_sources_by_operations type_arguments="unowned MediaPlugin" transfer_ownership="1"
> +
> +# GrlMediaPlugin
> +grl_media_plugin_get_info_keys type_arguments="unowned string" transfer_ownership="1"
> +
> +# GrlMediaSource
> +grl_media_source_browse.keys type_arguments="unowned KeyID" transfer_ownership="0"

The arguments can be marked as in/out/ref. By default are "in", and in this
case it doesn't matter the transfer_ownership (it is always false) neither the
ownership of the elements in the ship (are always unowned).

In other words, this line is spurious. And it is not desirable to maintain
useless lines of code.

> +grl_media_source_browse_sync type_arguments="Media" transfer_ownership="1"
> +grl_media_source_browse_sync.keys type_arguments="unowned KeyID" transfer_ownership="0"

ditto

> +grl_media_source_metadata.keys type_arguments="unowned KeyID" transfer_ownership="0"
> +grl_media_source_metadata_sync transfer_ownership="1"
> +grl_media_source_metadata_sync.keys type_arguments="unowned KeyID" transfer_ownership="0"

ditto

> +grl_media_source_query.keys type_arguments="unowned KeyID" transfer_ownership="0"
> +grl_media_source_query_sync type_arguments="Media" transfer_ownership="1"
> +grl_media_source_query_sync.keys type_arguments="unowned KeyID" transfer_ownership="0"

ditto 

> +grl_media_source_search.keys type_arguments="unowned KeyID" transfer_ownership="0"
> +grl_media_source_search_sync type_arguments="Media" transfer_ownership="1"
> +grl_media_source_search_sync.keys type_arguments="unowned KeyID" transfer_ownership="0"

ditto

> +
> +# GrlMetadataSource
> +grl_metadata_source_filter_slow type_arguments="unowned KeyID" transfer_ownership="1"
> +grl_metadata_source_filter_slow.keys type_arguments="unowned KeyID" transfer_ownership="0"

ditto

> +grl_metadata_source_filter_supported type_arguments="unowned KeyID" transfer_ownership="1"
> +grl_metadata_source_filter_supported.keys type_arguments="unowned KeyID" transfer_ownership="0"

ditto

> +grl_metadata_source_filter_writable type_arguments="unowned KeyID" transfer_ownership="1"
> +grl_metadata_source_filter_writable.keys type_arguments="unowned KeyID" transfer_ownership="0"

ditto

> +grl_metadata_source_resolve.keys type_arguments="unowned KeyID" transfer_ownership="0"
> +grl_metadata_source_resolve_sync.keys type_arguments="unowned KeyID" transfer_ownership="0"

ditto

> +grl_metadata_source_set_metadata.keys type_arguments="unowned KeyID" transfer_ownership="0"
> +grl_metadata_source_set_metadata_sync.keys type_arguments="unowned KeyID" transfer_ownership="0"

ditto

> +grl_metadata_source_key_depends type_arguments="unowned KeyID" transfer_ownership="0"
> +grl_metadata_source_slow_keys type_arguments="unowned KeyID" transfer_ownership="0"
> +grl_metadata_source_supported_keys type_arguments="unowned KeyID" transfer_ownership="0"
> +grl_metadata_source_writable_keys type_arguments="unowned KeyID" transfer_ownership="0"
> +
> +# GrlData
> +grl_data_get_keys type_arguments="unowned KeyID" transfer_ownership="1"
> +
> +# Error domain
>  GrlCoreError errordomain="1"
> +
> +# Callbacks
>  GrlMediaSourceMetadataCb hidden="1"
>  GrlMediaSourceRemoveCb hidden="1"
>  GrlMediaSourceResultCb hidden="1"
>  GrlMediaSourceStoreCb hidden="1"
>  GrlMetadataSourceResolveCb hidden="1"
> +
> +# Util
>  grl_list_from_va ellipsis="1"
> +
> +# Grilo
>  grl_init.argc hidden="1"
>  grl_init.argv is_array="1" is_ref="1" array_length_pos="0.9"