Re: [PATCH 7/7] tests: Removed setUp/tearDown code in python tests

[Víctor M. Jáquez L. <vjaquez igalia com>]

On Wed, Sep 29, 2010 at 01:38:44PM +0200, Simón Pena Placer wrote:
> 2010/9/29 Víctor M. Jáquez L. <vjaquez igalia com>:
> > On Tue, Sep 28, 2010 at 06:28:32PM +0200, Simón Pena wrote:
> >> ---
> >>  tests/python/test_metadata_source.py |    9 ++-------
> >>  tests/python/test_plugin.py          |    9 ++-------
> >>  tests/python/test_registry.py        |   22 ++++++++++++++--------
> >>  3 files changed, 18 insertions(+), 22 deletions(-)
> >
> > Why did you submitted this patch?
> >
> > I guess it is because the current register is not capable of plugins reloading
> > on-the-fly, but it isn't stated in the log message. In that way we would
> > revert it when the registry would get updated.
> 
> Ehm: yeah, in the previous cover-letter I said that I saw the first
> three patches ready to be pushed, but wasn't too sure about the tests
> themselves, and specially about this specific patch, which is a kind
> of hack to avoid the issue you mention: the crash when
> reloading/unloading. Sorry if I wasn't clear enough
> 

Aha... please try to keep all the information required to understand the
reason of the patch in its commit message.

vmjl