Re: [PATCH] annotations: Fixed transfer modes in grl-metadata-source

[Simón Pena Placer <spenap gmail com>]

On 28 September 2010 11:21, Iago Toral <itoral igalia com> wrote:
>
> On Tue, 28 Sep 2010 00:11:33 +0200, Simón Pena <spenap gmail com>
> wrote:
>> ---
>>  src/grl-metadata-source.c |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/grl-metadata-source.c b/src/grl-metadata-source.c
>> index 702a049..699d292 100644
>> --- a/src/grl-metadata-source.c
>> +++ b/src/grl-metadata-source.c
>> @@ -710,7 +710,7 @@ grl_metadata_source_resolve_sync
>> (GrlMetadataSource *source,
>>   * Compares the received @keys list with the supported key list by the
>>   * metadata @source, and will delete those keys which are supported.
>>   *
>> - * Returns: (element-type GObject.ParamSpec) (transfer full):
>> + * Returns: (element-type GObject.ParamSpec) (transfer container):
>>   * if @return_filtered is %TRUE will return the list of intersected keys;
>>   * otherwise %NULL
>>   */
>
> What's the rationale here? It is not only the hashtable that should be
> freed here, also the values stored in it.
>
> Iago
>

Hold the patch, then: I'll check it again. I found the "transfer full"
when I was completing the metadata info for the vapi generation for
Vala. It shocked me, as I thought I had already checked all the
transfer mode annotations, so feeling that I had missed them, I
changed the annotations to "container".

I'll confirm the right transfer mode later.

Cheers,

Simon