Re: [PATCH 0/2] Make =?UTF-8?Q?get=5Fsources=20and=20get=5Fsource?= =?UTF-8?Q?s=5Fby=5Foperations=20return=20GList?=



Hi Simón,

On Tue, 14 Sep 2010 21:18:27 +0200, Simón Pena <spenap gmail com>
wrote:
> Hi,
> 
> The following patches modify the API by making GrlPluginRegistry's
> get_sources and
> get_sources_by_operation return GLists instead of zero-terminated
> arrays. This change
> is related to the conversation we previously had in the list[1]. With
> this change, we'll
> avoid having to deal with JavaScript's unsupported arrays of types
> other than gchars: JS's
> GList support is complete.
> 
> I created bug #629369 at Bugzilla for them, bug I think they'll get a
> better review by
> coming to the list.

Pushed.

Found one issue though, your compare_by_rank function was incorrect, it
was selecting low-ranked plugins before high-ranked plugins (I fixed
this already).

Iago


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]