Re: [PATCH] core: fix GrlLog gtkdoc documentation
- From: Víctor M. Jáquez L. <vjaquez igalia com>
- To: Damien Lespiau <damien lespiau intel com>
- Cc: "grilo-list gnome org" <grilo-list gnome org>
- Subject: Re: [PATCH] core: fix GrlLog gtkdoc documentation
- Date: Tue, 14 Sep 2010 12:14:54 +0200
On Tue, Sep 14, 2010 at 10:56:57AM +0100, Damien Lespiau wrote:
> On Tue, 2010-09-14 at 10:51 +0100, Víctor Manuel Jáquez Leal wrote:
> > Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez igalia com>
>
> Looks good to me (If the CC. meant you wanted so review :)
Yep. I have configured my git send-email to check who wrote the line of code I
modified and add her/him in the Cc. It's part courtesy, review request and
noticing.
http://felipec.wordpress.com/2009/10/25/git-send-email-tricks/
>
> > - * This macro expands to nothing if debugging is disabled.
>
> The original idea was to provide a build time option to tune the debug
> messages left in the code (--enable-debug=<full,minimal,no>) but was
> never done. It's probably not vital.
Ah, now it makes sense.
vmjl
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]