Re: [PATCH 0/2] Reworked GrlMetadataSource's filters



Hi,

On 04/10/10 20:18, Simón Pena wrote:
Hi,

The following patches

* Rework the GrlMetadataSource's filter methods, by extracting common
   behavior into a generic filtering function
* Update the GrlMetadataSource's filter tests so that they check specific
   behavior instead of just the "instrospectable" status

Simón Pena (2):
   core: reworked GrlMetadataSource's filter methods
   tests: updated GrlMetadataSource filter tests

  src/grl-metadata-source.c            |  142 +++++++++++-----------------------
  tests/python/test_metadata_source.py |   18 ++++-
  2 files changed, 59 insertions(+), 101 deletions(-)


Looks like these patches got lost after GrlNet's ones. What do you think about them? Is the rewriting OK?

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]