Hi,
I had that change but I forgot to send it :)
I'll remember it when I push them.
Cheers,
--
Joaquim Rocha
On Fri, 2010-06-25 at 13:40 +0200, Iago Toral wrote:
> Hi Joaquim,
>
> I tested your patches (only up to the appple-trailers-plugin but I skimmed through
> some of the patches for other plugins too) and I think they are ok with one
> minor issue:
>
> you did not fix grilo's configure.ac to include the "grilo-0.1" naming convention
> instead of "grilo" for the plugin configuration directory, this should do the
> trick:
>
> +GRL_PLUGINS_CONF_DIR="${datadir}/${GRL_NAME}/plugins"
> -GRL_PLUGINS_CONF_DIR="${datadir}/${PACKAGE_NAME}/plugins"
>
> Other than that I think you can push the patches.
>
> Iago
>
> On Thu, 24 Jun 2010 09:05:30 +0200, Joaquim Rocha <jrocha igalia com>
> wrote:
> > Hi,
> >
> > After no strong objections to the changes of the plugins' XML names to be their IDs and the
> > change of their destination folder to be something different than the libraries' folder,
> > I've made such changes to the rest of the plugins.
> >
> > What should be different than the original patches is the usage of "grilo-0.1" instead of "grilo"
> > for the XML files' folder. Also, patch 0001 uses this define to replace the plugin's dir retrieval
> > that was using the same name but hardcoded.
> >
> > The pair of patches per plugin are analogous.
> >
> > Maybe someone should check this out before it's pushed because it was repetitive work which is error-prone.
> >
> >
> > Thank you,
> >
> > Joaquim Rocha (30):
> > Add new plugin's configuration dir to configure.ac
> > Use define with Grilo's name and version for Grilo plugins' dir
> > retrieval
> > applet-trailers: Add plugin ID from configure's constant
> > applet-trailers: Rename plugin's XML with the ID name
> > metadata-store: Add plugin ID from configure's constant
> > metadata-store: Rename plugin's XML with the ID name
> > vimeo: Add plugin ID from configure's constant
> > vimeo: Rename plugin's XML with the ID name
> > gravatar: Add plugin ID from configure's constant
> > gravatar: Rename plugin's XML with the ID name
> > shoutcast: Add plugin ID from configure's constant
> > shoutcast: Rename plugin's XML with the ID name
> > bookmarks: Add plugin ID from configure's constant
> > bookmarks: Rename plugin's XML with the ID name
> > podcasts: Add plugin ID from configure's constant
> > podcasts: Rename plugin's XML with the ID name
> > flickr: Add plugin ID from configure's constant
> > flickr: Rename plugin's XML with the ID name
> > youtube: Add plugin ID from configure's constant
> > youtube: Rename plugin's XML with the ID name
> > upnp: Add plugin ID from configure's constant
> > upnp: Rename plugin's XML with the ID name
> > lastfm-albumart: Add plugin ID from configure's constant
> > lastfm-albumart: Rename plugin's XML with the ID name
> > jamendo: Add plugin ID from configure's constant
> > jamendo: Rename plugin's XML with the ID name
> > filesystem: Add plugin ID from configure's constant
> > filesystem: Rename plugin's XML with the ID name
> > fake-metadata: Add plugin ID from configure's constant
> > fake-metadata: Rename plugin's XML with the ID name
> >
> > configure.ac | 65 ++++++++++++++++++++++++-
> > src/apple-trailers/Makefile.am | 8 +--
> > src/apple-trailers/grl-apple-trailers.c | 2 +-
> > src/apple-trailers/grl-apple-trailers.xml | 9 ++++
> > src/apple-trailers/libgrlappletrailers.xml | 9 ----
> > src/bookmarks/Makefile.am | 8 +--
> > src/bookmarks/grl-bookmarks.c | 2 +-
> > src/bookmarks/grl-bookmarks.xml | 9 ++++
> > src/bookmarks/libgrlbookmarks.xml | 9 ----
> > src/fake-metadata/Makefile.am | 8 +--
> > src/fake-metadata/grl-fake-metadata.c | 2 +-
> > src/fake-metadata/grl-fake-metadata.xml | 9 ++++
> > src/fake-metadata/libgrlfakemetadata.xml | 9 ----
> > src/filesystem/Makefile.am | 8 +--
> > src/filesystem/grl-filesystem.c | 2 +-
> > src/filesystem/grl-filesystem.xml | 9 ++++
> > src/filesystem/libgrlfilesystem.xml | 9 ----
> > src/flickr/Makefile.am | 8 +--
> > src/flickr/grl-flickr.c | 2 +-
> > src/flickr/grl-flickr.xml | 9 ++++
> > src/flickr/libgrlflickr.xml | 9 ----
> > src/gravatar/Makefile.am | 8 +--
> > src/gravatar/grl-gravatar.c | 2 +-
> > src/gravatar/grl-gravatar.xml | 9 ++++
> > src/gravatar/libgrlgravatar.xml | 9 ----
> > src/jamendo/Makefile.am | 8 +--
> > src/jamendo/grl-jamendo.c | 2 +-
> > src/jamendo/grl-jamendo.xml | 9 ++++
> > src/jamendo/libgrljamendo.xml | 9 ----
> > src/lastfm-albumart/Makefile.am | 8 +--
> > src/lastfm-albumart/grl-lastfm-albumart.c | 2 +-
> > src/lastfm-albumart/grl-lastfm-albumart.xml | 9 ++++
> > src/lastfm-albumart/libgrllastfm-albumart.xml | 9 ----
> > src/metadata-store/Makefile.am | 8 +--
> > src/metadata-store/grl-metadata-store.c | 2 +-
> > src/metadata-store/grl-metadata-store.xml | 9 ++++
> > src/metadata-store/libgrlmetadatastore.xml | 9 ----
> > src/podcasts/Makefile.am | 8 +--
> > src/podcasts/grl-podcasts.c | 2 +-
> > src/podcasts/grl-podcasts.xml | 9 ++++
> > src/podcasts/libgrlpodcasts.xml | 9 ----
> > src/shoutcast/Makefile.am | 6 +-
> > src/shoutcast/grl-shoutcast.c | 2 +-
> > src/shoutcast/grl-shoutcast.xml | 9 ++++
> > src/shoutcast/libgrlshoutcast.xml | 9 ----
> > src/upnp/Makefile.am | 8 +--
> > src/upnp/grl-upnp.c | 2 +-
> > src/upnp/grl-upnp.xml | 9 ++++
> > src/upnp/libgrlupnp.xml | 9 ----
> > src/vimeo/Makefile.am | 8 +--
> > src/vimeo/grl-vimeo.c | 2 +-
> > src/vimeo/grl-vimeo.xml | 9 ++++
> > src/vimeo/libgrlvimeo.xml | 9 ----
> > src/youtube/Makefile.am | 8 +--
> > src/youtube/grl-youtube.c | 2 +-
> > src/youtube/grl-youtube.xml | 9 ++++
> > src/youtube/libgrlyoutube.xml | 9 ----
> > 57 files changed, 246 insertions(+), 209 deletions(-)
> > create mode 100644 src/apple-trailers/grl-apple-trailers.xml
> > delete mode 100644 src/apple-trailers/libgrlappletrailers.xml
> > create mode 100644 src/bookmarks/grl-bookmarks.xml
> > delete mode 100644 src/bookmarks/libgrlbookmarks.xml
> > create mode 100644 src/fake-metadata/grl-fake-metadata.xml
> > delete mode 100644 src/fake-metadata/libgrlfakemetadata.xml
> > create mode 100644 src/filesystem/grl-filesystem.xml
> > delete mode 100644 src/filesystem/libgrlfilesystem.xml
> > create mode 100644 src/flickr/grl-flickr.xml
> > delete mode 100644 src/flickr/libgrlflickr.xml
> > create mode 100644 src/gravatar/grl-gravatar.xml
> > delete mode 100644 src/gravatar/libgrlgravatar.xml
> > create mode 100644 src/jamendo/grl-jamendo.xml
> > delete mode 100644 src/jamendo/libgrljamendo.xml
> > create mode 100644 src/lastfm-albumart/grl-lastfm-albumart.xml
> > delete mode 100644 src/lastfm-albumart/libgrllastfm-albumart.xml
> > create mode 100644 src/metadata-store/grl-metadata-store.xml
> > delete mode 100644 src/metadata-store/libgrlmetadatastore.xml
> > create mode 100644 src/podcasts/grl-podcasts.xml
> > delete mode 100644 src/podcasts/libgrlpodcasts.xml
> > create mode 100644 src/shoutcast/grl-shoutcast.xml
> > delete mode 100644 src/shoutcast/libgrlshoutcast.xml
> > create mode 100644 src/upnp/grl-upnp.xml
> > delete mode 100644 src/upnp/libgrlupnp.xml
> > create mode 100644 src/vimeo/grl-vimeo.xml
> > delete mode 100644 src/vimeo/libgrlvimeo.xml
> > create mode 100644 src/youtube/grl-youtube.xml
> > delete mode 100644 src/youtube/libgrlyoutube.xml
> >
> > _______________________________________________
> > grilo-list mailing list
> > grilo-list gnome org
> > http://mail.gnome.org/mailman/listinfo/grilo-list
> _______________________________________________
> grilo-list mailing list
> grilo-list gnome org
> http://mail.gnome.org/mailman/listinfo/grilo-list
Attachment:
signature.asc
Description: This is a digitally signed message part