Re: [PATCH] Do no add auto split to browse if less count are requested in browse



On Thu, 24 Jun 2010 16:37:47 +0200, Joaquim Rocha <jrocha igalia com>
wrote:
> Hi,
> 
> On Thu, 2010-06-24 at 14:59 +0200, Iago Toral wrote:
>> On Thu, 24 Jun 2010 13:22:27 +0200, Xabier Rodriguez Calvar
>> <xrcalvar igalia com> wrote:
>> > I was experiencing some weird crashes when testing my pagination code in
>> > mafw-grilo-source with my fremantle branches. I checked the fixes about
>> > pagination and I saw that there was one about do not setting the
>> > autosplit if we request less count than the auto split threshold, but it
>> > only applied to search and query, not to browse. I think it is also
>> > necessary for the browse operation, at least in the fremantle branch. I
>> > am sending the patch here.
>> 
>> I think I fixed that in master some weeks ago already, but thanks anyway :)
> 
> I have an updated master and I keep getting the crashes so I think it's
> not really fixed. I haven't tested Xabier's changes though.

Would be nice to know if that happens with specific backends... also, if you 
can reproduce the crash it would be nice to use gdb to get a backtrace and file 
a bug report.

Iago


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]