Re: [PATCH 5/5] vala: new vapi generation machinery

[Víctor M. Jáquez L. <vjaquez igalia com>]

On Mon, Jul 19, 2010 at 09:37:33PM +0200, Juan A. Suarez Romero wrote:
> On Mon, 2010-07-19 at 11:18 +0200, Víctor Manuel Jáquez Leal wrote:
> > + Add more custom code into the vapi. This is a _bad_ symptom, because
> > it
> >   means more diverging from the normal gobject code style.
> > 
> 
> 
> Where is exactly the problem in Grilo? Has something to do with the
> #defines and/or the static grilo keys?

The use of defines to keep some sort of API compatibility, but it breaks all
the automatic introspection. And then the use of global variables as part of
the API, it is not usual neither desirable, I reckon. Why not a factory
function?

vmjl