Re: [PATCH 0/3] doc: Some minor fixes



On Wed,  7 Jul 2010 18:12:40 +0200, Simón Pena <spenap gmail com> wrote:
> Hi,
> 
> While reading the docs provided and trying the examples, I noticed 
> that they weren't able to load the plugins, so after
> comparing the code with what's provided in the grilo-test-ui, I
> found that the call to grl_init was missing.

Yeah, that was indeed missing. Thanks!

> The first patch adds it, replacing the previous g_type_init
> call (as it's invoked inside grilo's init). The examples work now,
> but those plugins requiring extra configuration (flickr, vimeo and
> youtube) don't load. As I think the point in the examples is to be
> clear and brief, I didn't add the set_*plugin*_config code also found
> in the UI test, but it could be added, too.

Yup, I think that's ok.

> The second one consists on minor corrections for typos, misspells and
> the like.
> 
> In the third one, I removed some now-unused tags and renamed those more
> obvious to its current name. I wasn't brave enough to try to add tags
> for missing values, or doing less-than-obvious renaming.

I skimmed through the patches and I think they are all ok, I'll see if I can 
push them today.

Thanks a lot!

Iago


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]