Re: [PATCH 00/15] Rework of references counter in Specs

[Iago Toral Quiroga <itoral igalia com>]

El lun, 19-07-2010 a las 20:33 +0200, Juan A. Suarez Romero escribió:
> Hi.
> 
> This is a rework I did of this feature, taking in account Iago comments, and
> mostly, after hitting my head against the wall because I implemented it wrongly
> first time (kudos to Iago for enlighten me).
> 
> Anyway, some issues regarding the first set of patches (these ones invalidates
> the others, of course):
> 
>   (1) Specs are unreffered after source caller ends
>   (2) I added references counter to GrlMetadataSourceFooSpec structures
>   (3) Get rid of setters/getters in specs
...
> Again, comments are welcome. Please, note that I would like to do a release
> this week, so the sooner I get those comments, the better. Thanks.

I did not test the patches myself, but I reviewed them quickly and sent
comments about a couple of things, other than the issues I pointed out I
I am ok with pushing this, but remember to test this throughly before
pushing it. I suggest to do some tests with debug output on so that you
can ensure that things are freed when they should using grilo-test-ui,
probably comparing with the unpatched version to see if there are any
suspicious differences. A Valgrind run would also be interesting.

Iago