Re: Vimeo plugin

[Iago Toral Quiroga <itoral igalia com>]

Hi Joaquim,

I suggest that for patches like this that add a complete new feature, we
file a bug to bugzilla and attach the patch there (the size of the
attachment was a bit too much for the mailing list)

I'll look into the patch soon.

Iago

El lun, 26-04-2010 a las 09:57 +0200, Joaquim Rocha escribió:
> Hi,
> 
> Here goes my patch with the changes pointed by Victor.
> 
> Removed redundant commands from configure.ac, deleted trailing
> whitespaces and removed unused variable declaration.
> 
> 
> Cheers,
> 
> -- 
> Joaquim Rocha
> http://www.joaquimrocha.com
> 
> On Fri, Apr 23, 2010 at 3:46 PM, Joaquim Rocha
> <joaquimrocha1 gmail com> wrote:
>         Hi, I agree with Juan and that initialization is, in fact,
>         needed.
>         Libsoup async session is the one that requires it.
>         
>         I'll remove the unnecessary stuff Victor pointed out.
>         
>         
>         Cheers,
>         
>         -- 
>         Joaquim Rocha
>         http://www.joaquimrocha.com
>         
>         
>         
>         
>         On Fri, Apr 23, 2010 at 2:27 PM, Juan A. Suarez Romero
>         <jasuarez igalia com> wrote:
>                 On Fri, 2010-04-23 at 13:41 +0200, Víctor M. Jáquez L.
>                 wrote:
>                 
>                 > > +  if (!g_thread_supported ()) {
>                 > > +    g_thread_init (NULL);
>                 > > +  }
>                 >
>                 > I'm still not convinced if this initialization is
>                 really needed here.
>                 > IMHO
>                 > this is always carried out by the client
>                 application.
>                 
>                 
>                 Client shouldn't take care about how grilo's plugins
>                 are coded. So I'm
>                 not sure if this initialization should be done in
>                 client's side.
>                 
>                 Moreover, let's figure out that none of our plugins
>                 require gthread
>                 support, so clients wouldn't invoke g_thread_init.
>                 
>                 What would happen if a third-party plugin that
>                 requires gthread is
>                 installed in the system?. It is supposedly that client
>                 should be able to
>                 use it without rebuilding the client.
>                 
>                 
>                 IMHO, in Grilo, every plugin should initialize what
>                 they need to use.
>                 
>                        J.A.
>                 
>                 
>                 
>                 _______________________________________________
>                 grilo-list mailing list
>                 grilo-list gnome org
>                 http://mail.gnome.org/mailman/listinfo/grilo-list
>                 
>         
>         
>         
>         
> 
> 
> 
> _______________________________________________
> grilo-list mailing list
> grilo-list gnome org
> http://mail.gnome.org/mailman/listinfo/grilo-list