Re: Goocanvas in update from Gtk2 to Gtk3

[Paul Emsley <pemsley mrc-lmb cam ac uk>]

On 18/01/2021 08:05, damonachaplin gmail com wrote:
> On Sun, 2021-01-17 at 20:56 +0000, Paul Emsley via goocanvas-list
> wrote:
> > Hi Damon,
> >
> >
> > OK, so it seems that the problem is my end then. Hmm. So I went back
> > to
> > the demos (demo). I don't see the same problems there as I do in my
> > application, but I do see that the demo window does not have the
> > menu
> > bar, the canvas "flashes" - meaning nothing is displayed when I move
> > the
> > cursor out of the window (see attached) - but the normal purple box
> > is
> > shown when I bring focus back to the window. Also there is text in
> > the
> > console:
> >
> > $ ./demo
> > Ink Extents: 1608,2760 87744x15856  Logical: 0,0 90152x19072
> > Ink Extents: 1608,2760 59152x15856  Logical: 0,0 61560x19072
> > Ink Extents: -48,3264 40920x12176  Logical: 0,0 41672x19072
> > Ink Extents: 1608,3264 57440x15352  Logical: 0,0 59848x19072
> > Ink Extents: 1608,2760 40272x12680  Logical: 0,0 42680x19072
> > Ink Extents: 1608,2760 70504x15856  Logical: 0,0 72912x19072
> >
> > ** (demo:31813): WARNING **: 20:47:58.611: Could not find the
> > toroid.png
> > sample file
> > Is that normal?
> No, it's badly messed up. I'll send you an image of what it should look
> like. (Make sure you run the demo in the demo directory - that may fix
> the problems with the images at least.)


Oh, of course. (I had made an out of tree build.)

I get a number of add private warnings, e.g.

goocanvas.c:1130:13: warning: G_ADD_PRIVATE

I presume that I can ignore those.

Other than that, this is the only concern:

  CC       goocanvasitemsimple.lo
goocanvasitemsimple.c: In function 'goo_canvas_item_simple_set_model':
goocanvasitemsimple.c:1539:15: warning: assignment to 
'GooCanvasItemModelSimple *' {aka 'struct _GooCanvasItemModelSimple *'} 
from incompatible pointer type 'GooCanvasItemModel *' {aka 'struct 
_GooCanvasItemModel *'} [-Wincompatible-pointer-types]
 1539 |   item->model = g_object_ref (model);
      |               ^

> I just tried downloading the goocanvas source code:
> https://download.gnome.org/sources/goocanvas/2.0/goocanvas-2.0.4.tar.xz
>
> I ran "./configure" and then "make", then "cd demo", "./demo" and it
> worked fine. Try doing that.

I just did an "in tree" build and now the demo looks flawless and there 
are no "drawing failure for widget" errors.

I copied over toroid.png to the out-of-tree demo directory and ran it 
there. I get no longer get the "Could not find the toroid.png sample file"

message, but the "drawing failure for widget" errors remain, as do the 
missing menu bar and flashing graphics.


Paul