Re: Polymorphic GOData

Looks good for me. Just, I don't see why we need to change the arguments
order there:

@@ -93,7 +93,7 @@ gog_contour_plot_build_matrix (GogXYZPlot const *plot, gboolean *cardinality_cha
        for (i = 0; i < plot->rows; i++)
                for (j = 0; j < plot->columns; j++) {
                        val = gog_axis_map_to_view (map,
-                                       go_data_get_matrix_value (mat, j, i));
+                                       go_data_get_matrix_value (mat, i, j));
                        if (fabs (val) == DBL_MAX)
                                val = go_nan;
                        else {


Le mardi 21 avril 2009 à 17:16 +0200, Emmanuel Pacaud a écrit :

Here's a second try for the multi-dimensional GOData patch.

This time, the API compatibility is preserved. And the internal of
GOData is able to handle any number of data dimensions.

Please tell me what you think of this patch set.


gnumeric-list mailing list
gnumeric-list gnome org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]