Error feedback on graph data selection entries


I'm working on a patch for fixing an issue I've introduced a few months
ago, when trying to update the graph data when a data selection entry
lose the focus.

The issue introduced is if the expression is invalid when the expression
entry lose the focus, an error dialog appears, and will reappear as soon
as you close it.

My patch removes the error dialog and instead paint the expression entry
background in red when the expression is invalid, in  order to keep an
error feedback.

It's there:

One thing I don't like is the additional "update_entry" parameter I've
added to gnm_expr_entry_parse. But it's needed to avoid the automatic
quoting of entry.

Any comments ?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]