small patch for xml-io.c




Version 1.1.17 crashes for me when loading a workbook that contains
names.  It seems to me that the problem is in the function
xml_read_names in xml-io.c, in that the variable pp is only
initialized with a sheet, but later in the function sheetref_parse in
parse_util.c, the wb member of pp is used.

The following patch fixes this.

Best Regards,
Heath Martin


*** ../../gnumeric-1.1.17-pristine/gnumeric-1.1.17/src/xml-io.c
    2003-04-28 14:36:04.000000000 -0400
--- xml-io.c    2003-05-20 21:34:48.000000000 -0400
***************
*** 774,780 ****
                expr_str = xml_node_get_cstr (expr_node, NULL);
                g_return_if_fail (name_str != NULL && expr_str !=
                NULL);

!               parse_pos_init_sheet (&pp, sheet);
                if (position != NULL) {
                        xmlChar *pos_txt = xml_node_get_cstr
                        (position, NULL);
                        if (pos_txt != NULL) {
--- 774,780 ----
                expr_str = xml_node_get_cstr (expr_node, NULL);
                g_return_if_fail (name_str != NULL && expr_str !=
                NULL);

!               parse_pos_init (&pp, wb, sheet, 0, 0);
                if (position != NULL) {
                        xmlChar *pos_txt = xml_node_get_cstr
                        (position, NULL);
                        if (pos_txt != NULL) {




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]