Re: [GnomeMeeting-devel-list] [PATCH][Bug 171361] video slider settings reset after each call is back

[thomas schorpp <t schorpp gmx de>]

Damien Sandras wrote:
> Le lundi 06 mars 2006 à 13:40 +0100, thomas schorpp a écrit :
> 
>>Damien Sandras wrote:
>>
>>>Le lundi 06 mars 2006 à 05:19 +0100, thomas schorpp a écrit :
>>>
>>>
>>>>thomas schorpp wrote:
>>>>
>>>>

XXXXXXXXXXXX >>>>>old hack is broken, since spca5xx driver inits with *sane defaults* since last year fall.

>>>>>
>>>>>pls commit and users report if it breaks other drivers, especially auto-exposure enabled!
>>>>>
>>>>>manual re-adjustment on each call is unergonomical and gets on my nerves ;) 
>>>>>no autoexpo yet with aiptek dv 3500.
>>>>>
>>>>>y
>>>>>tom
>>>>>
>>>>>
>>>>
>>>>you can drop patch 1a or replace by this one if you want to work around 
>>>>spca5xx crashes with broken 2.6.15.5 usb which leads to kernel stalls.
>>>>
>>>
>>>
>>>Sorry, I can not apply this patch. This patch will force default values
>>>for all cameras. That is not correct, that is only a workaround for a
>>>problem which is specific to your camera. (lack of default values when
>>>you start).
>>>
>>>Better report the problem to its driver author.
>>>
>>
>>i did. no driver problem, since maybe not every sensor can do autoexpo/-brightness.
>>
> 
> 
> That is not a problem of autoexpo/brightness. The problem is that the
> driver doesn't return sane values for brightness/whiteness/...., but 0
> instead.

not longer 0, see above.

> Your patch forces those values to hardcoded values, which means
> that every time you are doing a call, it will force those settings.

... just until modifiing sliders manually.

> 
> The current code tries getting the current values from the webcam, if

no. therere *no* curent values. every driver will reset the sensors to *driver init* defaults 
*not* current or last(?). if not i'll check the spca driver why it resets, ok.

> the driver doesn't return 0, then it will update the sliders. 

doesnt work here anymore, other reports?

> 
> So I definitely think your patch is a bad idea, because it will force
> all webcams to be opened with hardcoded brightness.
> 

why should it be a bad idea if the values are a resonable middle and auto-brightness devices 
dont care anyway??

ok, your decision, too minor issue.

y
tom