Re: [GnomeMeeting-devel-list] [PATCH][Bug 171361] video slider settings reset after each call is back

[Damien Sandras <dsandras seconix com>]

Le lundi 06 mars 2006 à 13:40 +0100, thomas schorpp a écrit :
> Damien Sandras wrote:
> > Le lundi 06 mars 2006 à 05:19 +0100, thomas schorpp a écrit :
> > 
> >>thomas schorpp wrote:
> >>
> >>>old hack is broken, since spca5xx driver inits with defaults since last year fall.
> >>>
> >>>pls commit and users report if it breaks other drivers, especially auto-exposure enabled!
> >>>
> >>>manual re-adjustment on each call is unergonomical and gets on my nerves ;) 
> >>>no autoexpo yet with aiptek dv 3500.
> >>>
> >>>y
> >>>tom
> >>>
> >>>
> >>
> >>you can drop patch 1a or replace by this one if you want to work around 
> >>spca5xx crashes with broken 2.6.15.5 usb which leads to kernel stalls.
> >>
> > 
> > 
> > Sorry, I can not apply this patch. This patch will force default values
> > for all cameras. That is not correct, that is only a workaround for a
> > problem which is specific to your camera. (lack of default values when
> > you start).
> > 
> > Better report the problem to its driver author.
> > 
> 
> i did. no driver problem, since maybe not every sensor can do autoexpo/-brightness.
> 

That is not a problem of autoexpo/brightness. The problem is that the
driver doesn't return sane values for brightness/whiteness/...., but 0
instead. Your patch forces those values to hardcoded values, which means
that every time you are doing a call, it will force those settings.

The current code tries getting the current values from the webcam, if
the driver doesn't return 0, then it will update the sliders. 

So I definitely think your patch is a bad idea, because it will force
all webcams to be opened with hardcoded brightness.

> then drop the "a" patches and apply at least the "b", i know you dont want main.cpp to be 
> modified, it has r-r-r permissions on checkout. but it should be no 
> problem for any driver to startup with zero default values and then use 
> the manual set up slider values at subsequent capture startups?
> 
> do you really like to release ekiga with having to reset the sliders manually at every call 
> for none autoexpo drivers?
> 
> remember the spca50x driver supports 200 webcams. this should be the majority ;)
> auto-expo is supported only for the spca508 chip by now.
> 
> y
> tom
> 
> 
-- 
 _      Damien Sandras
(o-     
//\     Ekiga Softphone: http://www.ekiga.org/
v_/_    FOSDEM 2006    : http://www.fosdem.org/
        SIP Phone      : sip:dsandras ekiga net
                         sip:600000 ekiga net