Re: [GnomeMeeting-devel-list] small bug in stats_drawing_area

[Damien Sandras <dsandras seconix com>]

Hi,


Thanks, it will be applied to CVS tonight!


Le mercredi 06 avril 2005 à 00:27 +0200, Stefan Bruens a écrit :
> Hi,
> 
> there is a small bug in the stats drawing area.
> 
> In endpoint.cpp:
> ---
> if (gm_conf_get_int (USER_INTERFACE_KEY "main_window/control_panel_section") 
> == 0)
> gm_main_window_update_stats (main_window,
> ...
> ---
> 
> So the stats get only updated if the widget is visible. Unfortunately not only 
> the visible stats is affected, but also the ringbuffer with the transfer 
> speeds. To see the effect, during a call switch away from statistics pane, 
> wait some seconds, and switch back - there will be a peak in the graph, as 
> the data transfered during this time will be accumulated.
> 
> To fix this, the appeded fix does the following:
> 1) call gm_main_window_update_stats unconditionally
> 2) check for GTK_WIDGET_REALIZED() in the graph widget
> 3) check for GTK_WIDGET_REALIZED() when setting the labels in the statistics 
> pane
> 
> Additionally, the patch cleans up stats_drawing_area.c a little bit:
> 1) adjust the ringbuffer size in the allocation to the size used in the rest 
> of the code (100 -> 50)
> 2) optimize the calculation for the maximum transfer speed
> 3) put the calculation of the grid segments into the size_allocate function
> 
> Everything open for discussion ...
> 
> The patch has been tested with 1.2.1, but I have prepared versions for 1.2.1 
> and OPAL_BRANCH. The first patch is for both Branches, the second comes in 
> two versions.
> 
> Greetings,
> 
> Stefan
> 
> _______________________________________________
> Gnomemeeting-devel-list mailing list
> Gnomemeeting-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnomemeeting-devel-list
-- 
 _      Damien Sandras
(o-     GnomeMeeting: http://www.gnomemeeting.org/
//\     FOSDEM 2005 : http://www.fosdem.org
v_/_    H.323 phone : callto:ils.seconix.com/dsandras seconix com