Re: [GnomeMeeting-devel-list] [PATCH] removes unneeded begin/end call notification in text-chat

[Damien Sandras <damien sandras it-optics com>]

Le jeu 22/01/2004 à 14:22, PUYDT Julien a écrit :
> Hi,
> 
> the current notification in text-chat has two problems:
> * if the call doesn't really happen (you don't answer or deny the call),
> you still get the call end message;
> * if no text chat occurs, you still get the call begin/end messages;
> 
> This patch fixes both problems.
> 
> Notice that:
> * it introduces new variables in a structure, but those should be
> considered as do-not-read and do-not-modify outside of chat_window.cpp;
> * in src/gnomemeeting.cpp, there is a: chat = new GmTextChat (); (that
> doesn't really initialize anything as far as I know, since GmTextChat is
> just a struct) and in src/main_window.cpp: gw->chat_window =
> gnomemeeting_text_chat_new (chat); (that has the side-effect that it
> really does initialize the chat!). I find it wrong...
> 

The structure are initialized in the gnomemeeting constructor and
destroyed in the gnomemeeting destructor. I understand your approach,
but I think it is cleaner the way it is. Otherwise you would have
allocation at several places in the code and destruction concentrated
elsewhere.

The patch is ok, perhaps Kilian can commit (Snark, you should ask for a
CVS account).

> Snark
-- 
 _      Damien Sandras
(o-     
//\     It-Optics s.a.
v_/_    GnomeMeeting: http://www.gnomemeeting.org/
        FOSDEM 2004:  http://www.fosdem.org
        H.323 phone:  callto:ils.seconix.com/dsandras seconix com