Re: [GnomeMeeting-devel-list] [PATCH] gnomemeeting_log_insert cleaning



On jeu, 2004-01-22 at 11:37, Damien Sandras wrote:
> Le jeu 22/01/2004 à 11:31, PUYDT Julien a écrit :
> > No, because "history" is where you put the list of
> > placed/received/missed calls, and "log" is where you put information
> 
> No, there is the calls history and the history.

That doesn't make reading the sources easy if everything is called
"history"...

> > that may turn out useful to debug a problem... that is the reason why I
> > would be more inclined to make another patch to rename the
> > history_text_view to log_text_view than what you propose. 
> 
> then change it, but also change all the functions creating and
> manipulating the general history window. Also rename the menu items, and
> the GConf keys that remember the positions and sizes as
> "general_history". Also rename the pointers in common.h. 

Aie... :-(
Then it cannot be done seriously, at least not before 1.00...

Snark




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]