Re: [GnomeMeeting-devel-list] [PATCH] gnomemeeting_log_insert cleaning

[Damien Sandras <damien sandras it-optics com>]

Hello Julien,

The patch is correct (thanks!) and you can send it to Kilian, but here
are a few remarks :

- There are no thread-safe problems with the 2 FIXME, the only thing
that has to be between *_threads_* are calls that modify the GUI.

- Have you removed #include "misc.h" where they were not needed anymore
due to the change?

- Wouldn't we rename gnomemeeting_log_insert in gnomemeeting_history_add
or something so?

Thank you!

Le mer 21/01/2004 à 21:54, PUYDT Julien a écrit :
> Hi,
> 
> the following patch does several (closely related) things:
> * the gnomemeeting_log_insert function now lives in tools.* instead of
> misc.* (it is just a move, the source didn't change on that part)(the
> includes have been changed accordingly);
> * the current function did take a text view as arguments, but it was the
> same all over the place ; now it is not an argument anymore (all the
> places that used the function where changed accordingly);
> * some places in the code didn't use that function's formatting
> features: now they do (little quirk: in lid.cpp [a place in the code I
> can't test for lack of proper hardware], there are two places where I'm
> not sure the pre-formatting in a msg outside a lock claim wasn't on
> purpose to avoid problems -- search for "FIXME" in the patch).
> 
> Snark
-- 
 _      Damien Sandras
(o-     
//\     It-Optics s.a.
v_/_    GnomeMeeting: http://www.gnomemeeting.org/
        FOSDEM 2004:  http://www.fosdem.org
        H.323 phone:  callto:ils.seconix.com/dsandras seconix com