[GnomeMeeting-devel-list] Option Menu Mnemonics in Preferences Dialog

[Rodney Dawes <dobey free fr>]

Earlier today on IRC, damien and fabrice were discussing something about
mnemonics and the Advanced Prefs and one particular option menu in it.
The same issue holds true for any option menu that uses the
gnome_prefs_int_option_menu_new () abstraction that is in gnomemeeting,
where the mnemonic doesn't work. It was suggested that the label in the
option menu be modified to include the mnemonic.

Attached is a patch which fixes these issues. So, assuming that you have
a mnemonic set in the label that gets shoved in the hbox before the
GtkOptionMenu, it will work. This also assumes that there are no other
mnemonics with the same letter in the same page of the dialog, including
the dialog buttons and any other widgets that aren't specific to certain
pages.

If anyone is doing a review of the HIG and/or the UI in gnomemeeting,
the mnemonics and strings, and their widget attachments, need to be
seriously checked out. Just looking at the screenshot that damien
pointed me to, to look at the page in question, frightened me with it's
lack of proper capitalization in strings, and overuse of the same
mnemonics in multiple widgets on the same page, as well as the use of
arbitrary letters in the string, for the mnemonic. This patch also fixes
the label to have a better string for the one widget in question, which
is the only widget that sits under the grouping that it is in.

Since this changes a string, the translations will need to be updated as
well.

-- dobey

? autom4te.cache
? gnomemeeting.schemas
? gnomemeeting.schemas.in
? stamp-h1
? lib/Makefile
? lib/Makefile.in
? lib/widgets/Makefile
? lib/widgets/Makefile.in
? lib/xdap/Makefile
? lib/xdap/Makefile.in
? man/Makefile
? man/Makefile.in
? pixmaps/inline_emoticons.h
? pixmaps/inlines.h
? sounds/gnomemeeting.soundlist
? src/gnomemeeting-config-tool
? xdap_data/Makefile
? xdap_data/Makefile.in
Index: lib/gnome_prefs_window.c
===================================================================
RCS file: /cvs/gnome/gnomemeeting/lib/gnome_prefs_window.c,v
retrieving revision 1.2
diff -u -r1.2 gnome_prefs_window.c
--- lib/gnome_prefs_window.c	2 Nov 2003 22:01:54 -0000	1.2
+++ lib/gnome_prefs_window.c	4 Nov 2003 01:35:14 -0000
@@ -430,6 +430,8 @@
   menu = gtk_menu_new ();
   option_menu = gtk_option_menu_new ();
 
+  gtk_label_set_mnemonic_widget (GTK_LABEL (label), option_menu);
+
   while (options [cpt]) {
 
     item = gtk_menu_item_new_with_label (options [cpt]);
Index: src/pref_window.cpp
===================================================================
RCS file: /cvs/gnome/gnomemeeting/src/pref_window.cpp,v
retrieving revision 1.182
diff -u -r1.182 pref_window.cpp
--- src/pref_window.cpp	2 Nov 2003 22:01:55 -0000	1.182
+++ src/pref_window.cpp	4 Nov 2003 01:35:16 -0000
@@ -826,7 +826,7 @@
 				_("User Input Capabilities"), 1, 1);
 
   pw->uic =
-    gnome_prefs_int_option_menu_new (subsection, _("User Input Capabilities _type:"), capabilities, GENERAL_KEY "user_input_capability", _("This permits to set the mode for User Input Capabilities. The values can be \"All\", \"None\", \"rfc2833\", \"Signal\" or \"String\" (default is \"All\"). Choosing other values than \"All\", \"String\" or \"rfc2833\" disables the Text Chat."), 0);
+    gnome_prefs_int_option_menu_new (subsection, _("T_ype:"), capabilities, GENERAL_KEY "user_input_capability", _("This permits to set the mode for User Input Capabilities. The values can be \"All\", \"None\", \"rfc2833\", \"Signal\" or \"String\" (default is \"All\"). Choosing other values than \"All\", \"String\" or \"rfc2833\" disables the Text Chat."), 0);
 }