Re: Let's get rid of deprecation warnings

[Georges Basile Stavracas Neto <georges stavracas gmail com>]

We should also update from deprecated widgets too. There are 4 widgets that still plague Settings, and they have simple replacements:

• GtkHBox, GtkVBox: can be replaced by a GtkBox with the orientation property set
• GtkAdjustment: can be replaced by setting the halign/valign properties of the target widget
• GtkTable: a bit more laborious, but can be replaced by GtkGrid

An obviously simple way to chase these widgets down is using git grep. And again, replacing them is an easy task suitable for newcomers.

Em qua, 7 de mar de 2018 às 08:57, Bastien Nocera <hadess hadess net> escreveu:

On Wed, 2018-03-07 at 11:22 +0000, Robert Ancell wrote:
>
>
> On Wed, 7 Mar 2018 at 01:59 Georges Basile Stavracas Neto <georges.st
> avracas gmail com> wrote:
> > Greetings,
> >
> > By the time this mail is being written, compiling GNOME Settings
> > produces no less than 198 deprecation warnings. As the central hub
> > of settings of GNOME, this situation is not ideal.
> >
> > If you are a maintainer of a panel and have some spare time, please
> > try and update your panel. If you can't do that, please let us
> > know.
> >
> > Removing deprecation warnings is also a good way to get people
> > interested in contributing to Settings bootstraped.
> >
> > Don't hesitate to share your thoughts on this topic.
> >
> >
>
> I think this is an important issue, thanks for raising in Georges!
>
> In my experience I've found projects with a lot of warnings:
> - are easy to introduce bugs into because it's not clear when new
> warnings appear.
> - tend to grow a culture of not keeping the code in good shape.
> - are unappealing for contributions (in the case of Settings that is
> true for me - it's one of the less appealing projects to hack on).

Disabling deprecation warnings is the easy way to fix this...

They're also incomplete anyway, as they won't warn about deprecated
widgets used in GtkBuilder files for example.