Re: Let's get rid of deprecation warnings

[Bastien Nocera <hadess hadess net>]

Hey,

On Wed, 2018-03-07 at 00:59 +0000, Georges Basile Stavracas Neto wrote:
> Greetings,
>
> By the time this mail is being written, compiling GNOME Settings
> produces no less than 198 deprecation warnings. As the central hub of
> settings of GNOME, this situation is not ideal.
>
> If you are a maintainer of a panel and have some spare time, please
> try and update your panel. If you can't do that, please let us know.
>
> Removing deprecation warnings is also a good way to get people
> interested in contributing to Settings bootstraped.
>
> Don't hesitate to share your thoughts on this topic.

I don't think that "getting rid of deprecation" should be a goal unto
itself, but rather part of the review process. When a patch touches a
section that has deprecation warnings, it's probably fine to touch up
the code to get rid of those warnings and modernise the section of
code, but doing it as a "goal" really is dangerous as that has usually
lead to additional bugs, and crashes.

I'd focus on deprecated warnings for non-GLib, non-GTK+ libraries
first, as those will drop deprecated functions faster. For GTK+, the
migration should be part of design touchups and GTK+ 4.x porting.

Cheers