Re: File Transfer Dialog

[Thomas Wood <thos gnome org>]

I just committed my changes to the file transfer dialog. For the moment,
I have added a new parent property to the file transfer dialog object,
and I've also added a new_with_parent constructor which I will use once
I have committed some other changes to the theme applet.

Does anyone know if the file transfer dialog (which is in
capplets/common) is used anywhere else other than the theme manager? If
not then I will modify the original file_transfer_dialog_new function to
accept a parent parameter and get rid of the new_with_parent constructor.

-Thomas

Calum Benson wrote:
> On Tue, 2006-10-31 at 12:20 +0000, Thomas Wood wrote:
> 
>> Here is my latest attempt. If this looks OK to everyone I will commit. I
>> have removed the "Copying files 1 of 1" unless there is actually more
>> than one file being copied. I might also try and allow the title to
>> match the parent window (in this case "Theme Manager") if that sounds
>> sensible.
>>
>> Any more thoughts?
> 
> Looks fine, the title bar text just needs a little tweaking as you say.
> 
> Only other thing that springs to mind might be trying to extract the
> theme name from the tarball up front, and using that in the dialog
> instead of the rather more cryptic tarball filename.  Dunno how much
> that would slow things down though, and I suppose it would make the
> description of what was occurring a tad less accurate...
> 
> Cheeri,
> Calum.
>