Re: [PATCH] binding to arbitrary shell commands

[Rodrigo Moya <rodrigo novell com>]

On Tue, 2006-01-10 at 20:41 +0100, Xavier Claessens wrote:
> Le mardi 03 janvier 2006 à 21:48 +0100, Xavier Claessens a écrit :
> > Le mardi 03 janvier 2006 à 16:20 +0100, Rodrigo Moya a écrit :
> > > On Thu, 2005-12-22 at 18:40 +0100, Claessens Xavier wrote:
> > > > Le lundi 28 novembre 2005 à 17:53 +0100, Claessens Xavier a écrit :
> > > > > Hi,
> > > > > 
> > > > > There is a patch on bug 114796 [1] waiting for a review. Can someone
> > > > > tell me if there is something wrong or something can be better ? Or
> > > > > simply commit the patch...
> > > > > 
> > > > > Thanks,
> > > > > Xavier Claessens.
> > > > > 
> > > > > [1] http://bugzilla.gnome.org/show_bug.cgi?id=114796
> > > > 
> > > > UP ! nobody care ?
> > > 
> > > sorry for the delay :) It seems the patch is ok, but could you please
> > > resend it based on current CVS HEAD?
> > > 
> > > Once you do that, if nobody disagrees, I'll commit the patch.
> > 
> > Done. I've not tested the new version extensively but it should work...
> > 
> > Thanks.
> > 
> > Xavier Claessens.
> 
> Is it possible to have it reviewed as soon ? Feature freeze is at 16/01
> (6days remaining !!) or I miss understand schedule ? This patch was
> already there for 2.12, I want it in time for 2.14 if there is no major
> bug in the patch...
> 
reviewing it now, will add any more comments to the bug.

Thanks for the patch and sorry for the delay
-- 
Rodrigo Moya <rodrigo novell com>