Re: Code freeze break request

[Vincent Untz <vuntz gnome org>]

Le vendredi 07 mars 2008, à 12:38 +0100, Alexander Larsson a écrit :
> 
> On Fri, 2008-03-07 at 12:36 +0100, Vincent Untz wrote:
> 
> > > --- hal/ghalmount.c	(revision 1602)
> > > +++ hal/ghalmount.c	(working copy)
> > > @@ -209,9 +209,9 @@
> > >      }
> > >    
> > >    if (is_blank)
> > > -    return disc_data[n].ui_name_blank;
> > > +    return gettext(disc_data[n].ui_name_blank);
> > >    else
> > > -    return disc_data[n].ui_name;
> > > +    return gettext(disc_data[n].ui_name);
> > >  }
> > 
> > Why aren't you using _()? Else, approval 1 of 2.
> 
> Wouldn't that mark it for translation?

I think not. It only mark things for translation when they are constant
strings (as in "something") and not when they are variables. At least, I
seriously hope it does this :-)

Vincent

-- 
Les gens heureux ne sont pas pressés.