Re: [Patch] gio-standalone build fail with suncc because retrun value in void function

[Takao Fujiwara <Takao Fujiwara Sun COM>]

I thought it's a handy fix since we(each vendor) owns our .spec files.

http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/head/grp.h
_POSIX_PTHREAD_SEMANTICS is defined in Sun's /usr/include/grp.h :
--------------
 * NOTE: Support for the Draft 6 definitions is provided for compatibility
 * only.  New applications/libraries should use the standard definitions.

#if     (_POSIX_C_SOURCE - 0 >= 199506L) || defined(_POSIX_PTHREAD_SEMANTICS)

#ifdef __PRAGMA_REDEFINE_EXTNAME
#pragma redefine_extname getgrgid_r __posix_getgrgid_r
#pragma redefine_extname getgrnam_r __posix_getgrnam_r
extern int getgrgid_r(gid_t, struct group *, char *, int, struct group **);
extern int getgrnam_r(const char *, struct group *, char *, int,
                                                        struct group **);
#else  /* __PRAGMA_REDEFINE_EXTNAME */

extern int __posix_getgrgid_r(gid_t, struct group *, char *, size_t,
    struct group **);
extern int __posix_getgrnam_r(const char *, struct group *, char *, size_t,
    struct group **);
--------------

I just thought gio is implemented on the standard POSIX.


> "glocalfile.c", line 748: unexpected "("
> "glocalfile.c", line 777: undefined symbol: unescaped_path
>

Is this a bug? or does your system has the extern 'unescaped_path' ?

--- gio-standalone-0.1.1/gio/glocalfile.c.orig  2007-11-07 14:06:09.041578000 +0900
+++ gio-standalone-0.1.1/gio/glocalfile.c       2007-11-07 14:16:48.661172000 +0900
@@ -749,7 +749,7 @@ g_local_file_query_filesystem_info (GFil
 #endif

 #elif HAVE_STATVFS
-  statfs_result = statvfs (unescaped_path, &statfs_buffer);
+  statfs_result = statvfs (local->filename, &statfs_buffer);
   block_size = statfs_buffer.f_frsize;
 #endif



Alexander Larsson さんは書きました:
> On Wed, 2007-11-07 at 17:01 +0900, Takao Fujiwara - Tokyo S/W Center
> wrote:
> > I think it can be resolved to set $CFLAGS instead of changing any codes on Solaris.
> >
> > export CFLAGS="%optflags -D_POSIX_PTHREAD_SEMANTICS"
>
> I commited the patch before i saw this mail, since I sort of rely on you
> guys to get the best approach on solaris.
>
> However, i think the ideal solution is to have an autoconf check that
> actually tries getpwuid_r and figures out how the arguments look. That
> way it will build correctly on solaris independent on whether the user
> specified _POSIX_PTHREAD_SEMANTICS or not, and it will work on other
> OSes that have the same arguments as solaris has.
>
> Anyone want to look into this?
>
>
> _______________________________________________
> gnome-vfs-list mailing list
> gnome-vfs-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnome-vfs-list