Re: [Patch] gio-standalone build fail on solaris because of statfs is different with Linux

[Halton Huo <Halton Huo Sun COM>]

"glocalfile.c", line 748: unexpected "("
"glocalfile.c", line 777: undefined symbol: unescaped_path

Any IRC are you logged in?

Seems you committed the patch for getpwuid_r and getgrgid_r, do you
think Fujiwara's way is better?

Halton.

On Wed, 2007-11-07 at 10:15 +0100, Alexander Larsson wrote:
> On Wed, 2007-11-07 at 09:45 +0100, Alexander Larsson wrote:
> > On Wed, 2007-11-07 at 16:26 +0800, Halton Huo wrote:
> > > Hi Alexl,
> > > 
> > > When I try to build gio-standalone trunk code on Solaris with suncc, I
> > > get build fail with following message:
> > > 
> > > /ws/onnv-tools-prc/SUNWspro/SS11/bin/cc -DHAVE_CONFIG_H -I. -I.. -I..
> > > -I.. -DGIO_MODULE_DIR=\"/export/home/halton/work/dist/lib/gio/modules
> > > \" -D_REENTRANT -D_PTHREADS -I/usr/include/glib-2.0
> > > -I/usr/lib/glib-2.0/include -DG_LOG_DOMAIN=\"GIO\"
> > > -DG_DISABLE_DEPRECATED -DDBUS_API_SUBJECT_TO_CHANGE
> > > -D_POSIX_PTHREAD_SEMANTICS -c glocalfile.c  -KPIC -DPIC
> > > -o .libs/glocalfile.o
> > > "glocalfile.c", line 777: undefined struct/union member: f_type
> > > 
> > > On Solaris:
> > > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/sys/statfs.h
> > > 
> > > f_type is f_fstyp
> > > does not have f_bavail
> > > 
> > > The patch is attached.
> > 
> > 
> > This doesn't seem right. Shouldn't you be using statvfs instead on sun.
> > That way you can get the amount of free space.
> 
> I checked in something that should do this. Can you verify that it
> works?
> 
> 
-- 
Halton Huo
Solaris Desktop Team, Sun Microsystems
Tel: +86-10-82618200 ext. 82113/ +86-10-626732113
Fax: +86-10-62780969
eMail: Halton Huo Sun COM