Re: [PATCH] Improved sftp I/O error handling

[Alexander Larsson <alexl redhat com>]

On Mon, 2007-05-21 at 15:41 +0200, Christian Neumair wrote:
> The attached patch ensures that buffer_recv and buffer_send errors are
> propagated to their parents. While hangs may still occur, crashes
> shouldn't happen anymore.

Looks good to me from a quick look, please commit.
I have one questions though. This hunk:

@@ -2314,13 +2357,24 @@ do_write (GnomeVFSMethod       *method, 
 			buffer_write_block (&msg, buffer + write_req[req_ptr].offset,
 					    write_req[req_ptr].req_len);
 			
-			buffer_send (&msg, handle->connection->out_fd);
+			res = buffer_send (&msg, handle->connection->out_fd);
 
 			req_ptr = (req_ptr + 1) % queue_len;
 		}

Are you sure we always check that result? What if we loop again?


=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an old-fashioned bohemian inventor living undercover at Ringling Bros. 
Circus. She's a cynical psychic barmaid from a different time and place. They 
fight crime!