Re: [PATCH] "Fixup" smb:/// entries



On Mon, 2006-12-25 at 13:35 +0100, Christian Neumair wrote:
> Am Montag, den 25.12.2006, 02:26 +0100 schrieb Christian Neumair:
> > Am Montag, den 25.12.2006, 02:12 +0100 schrieb Christian Neumair:
> > > The attached patch is a crude hack (like most of smb:///) to "fix" the
> > > issue that Nautilus messes up MIME types of smb://(/) contents all the
> > > time (thus flipping directory and launcher MIME types), by constructing
> > > separate "smb:///foo.desktop" and "smb://foo" entries. At the moment, I
> > > think the issue is that Nautilus/GnomeVFS use some textual mechanism for
> > > comparing URIs that ignores subsequent slashes, not realizing that
> > > smb:///foo and smb://foo are different entities, and goes crazy when
> > > trying to follow a link pointing to itself, pretending to be both a
> > > directory and a launcher.
> > > 
> > > We don't really have a concept when "proto://" and "proto:///" are
> > > considered identical, IIRC some modules even convert the URI to string
> > > and skip these slashes in its handlers. From a user perspective, having
> > > a root URI and a separate host construction seems unintuitive, so this
> > > might actually be the more "correct" route.
> > > 
> > > Hopefully fixes http://bugzilla.gnome.org/show_bug.cgi?id=356093
> > 
> > Eww sorry, please let me rethink this one. It's getting late, and I
> > heard to much Jazz. I probably identified the cause of the issue
> > correctly, but the patch breaks the file info name, at least for work
> > group/server links.
> 
> Although the original but report seems to have been a VFS daemon issue,
> I'm attaching a patch that will clarify the desktop files to end in
> ".desktop" (so that even their file names are a hint that they are
> links), and attaches some documentation where it is neccessary.
> 
> It is definitly just a face lift, but computer:/// also uses special
> file extensions to clarify that we're dealing with links.
> 
> It will also prevent the module from generating links from "smb:///foo"
> to "smb://foo", which is IMO quite unintuitive because you can easily
> confuse them.
> 
> How the SMB module will work after the patch:

Unfortunately we can't just mess around with smb: uris however we want.
There is a standard for how they work:
http://www.ietf.org/internet-drafts/draft-crhertel-smb-url-11.txt

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an uncontrollable soccer-playing matador on the wrong side of the law. 
She's a vivacious cat-loving mercenary with a knack for trouble. They fight 
crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]