Re: patch nag: refcount neon module

[Alexander Larsson <alexl redhat com>]

On Thu, 2006-09-14 at 21:48 +0200, Christian Neumair wrote:
> Handling multiple methods in one module requires refcounting, which
> currently isn't implemented properly for the neon method.
> http://bugzilla.gnome.org/show_bug.cgi?id=347470 provides a patch.

Looks good. Please commit.

> Sidenote: We never g_module_close the modules opened for one
> MethodElement. Since GModules are refcounted, we should be able to
> safely close them in module_element_free, even when used with multiple
> methods.

This is dangerous, as things might still somehow reference code or data
in those .so files. At the very least we shouldn't do anything like this
in the stable series.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a superhumanly strong coffee-fuelled matador haunted by an iconic dead 
American confidante She's a cold-hearted mutant archaeologist who believes she 
is the reincarnation of an ancient Egyptian queen. They fight crime!