Re: [PATCH] computer:/// should display all drives, not only user-visible ones

[Alexander Larsson <alexl redhat com>]

On Tue, 2006-05-23 at 19:40 +0200, Xavier Claessens wrote:
> Le mardi 23 mai 2006 à 14:35 +0200, Alexander Larsson a écrit :
> > On Mon, 2006-05-22 at 18:07 +0200, Xavier Claessens wrote:
> > > Hi,
> > > 
> > > I've attached an improved patch for bug #341446 [1]. Can someone review
> > > the patch and commit it to gnome-2-14 and HEAD, plz ?
> > > 
> > > Thanks,
> > > Xavier Claessens.
> > > 
> > > [1] http://bugzilla.gnome.org/show_bug.cgi?id=341446
> > 
> > Could you explain exactly why this patch is better? All it seems to do
> > is change the semantics of volumes in drives such that you get new file
> > + old file removed instead of just the existing one changed. I think
> > this will cause some strange issues due to the renaming, for instance
> > all metadata for the file in nautilus is based on the filename, so when
> > the drive gets mounted the icon will move somewhere else.
> > 
> 
> The problem is that now auto-mountable drives are no longer user-visible
> because it can be mounted without user action. So for example CDROM
> drives aren't displayed in computer:///.
> 
> I think computer:/// should still display cdroms so I posted the first
> patch which remove the user-visible check. It has the disadvantage that
> every volumes is now shown, for example I see an icon for my / partition
> and my /home partition. which isn't a good idea, I think.

We changed is_user_visible for drives to mean "can mount automatically".
How exactly does that affect what volumes (not drives) are shown? I need
to understand exactly what is going wrong here. I though that before we
always just set all drives to be user visible, so changing that and then
ignoring that setting in computer:// should produce no difference.

> Another thing is that, if I understand
> gnome_vfs_drive_get_mounted_volumes(), a drive can have more than one
> volume when mounted. With actual implementation I don't understand how
> it can work, let say I have such drive unmounted, so it has his icon on
> computer:///, I get the mount signal and update this drive but what
> happens if more that one volume comes from one single drive ? I'm not
> sure about that.

Yes. This was something that was added later, and we probably didn't fix
up computer:// to handle that. Needs some looking into.

> What I can do is adding a drive if it's unmounted or if his volume(s) is
> user-visible. But I didn't do that way because I don't know how to
> manage drives that have more than one volume, is it possible to have 2
> volumes one is user-visible and not the other ?
> 
> Please tell me what's the better solution, I can make a patch for my
> last suggestion if you want.

I need to figure out exactly what goes wrong first.

> We should solve this problem ASAP because ubuntu dapper is released in
> one week...

You could always revert the previous patches.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a Nobel prize-winning misogynist firefighter living undercover at 
Ringling Bros. Circus. She's a radical hip-hop Hell's Angel who dreams of 
becoming Elvis. They fight crime!