Re: [PATCH] computer:/// should display all drives, not only user-visible ones

[Alexander Larsson <alexl redhat com>]

On Mon, 2006-05-22 at 18:07 +0200, Xavier Claessens wrote:
> Hi,
> 
> I've attached an improved patch for bug #341446 [1]. Can someone review
> the patch and commit it to gnome-2-14 and HEAD, plz ?
> 
> Thanks,
> Xavier Claessens.
> 
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=341446

Could you explain exactly why this patch is better? All it seems to do
is change the semantics of volumes in drives such that you get new file
+ old file removed instead of just the existing one changed. I think
this will cause some strange issues due to the renaming, for instance
all metadata for the file in nautilus is based on the filename, so when
the drive gets mounted the icon will move somewhere else.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a scrappy white trash photographer on the edge. She's a provocative 
paranoid lawyer trying to make a difference in a man's world. They fight 
crime!