Re: [PATCH] Improve docs, new attempt



I only read about half of your patch, and not even all of it carefully, but
here are a couple of suggestions:

+ * Either way, it acts like #GnomeVFSXferProgressCallback
+ * would act in non-asynchronous mode. The differences in
+ * invocation are explained in the gnome_vfs_async_xfer()
+ * documentation documentation.

-> 2x documentation.

+ * @GNOME_VFS_FILE_TYPE_REGULAR: The file is regular (stat: %S_ISDIR).
+ * @GNOME_VFS_FILE_TYPE_DIRECTORY: The file is a directory (stat:
%S_ISREG).

-> "The file is a regular file"
-> %S_ISDIR and %S_ISREG are swapped.

+ * @GNOME_VFS_PERM_USER_READ: Owner has read permission.
etc...

-> permission*s* ?

+ * @GNOME_VFS_PERM_OTHER_ALL: Others have all permissionss.

-> permission*ss* !

+ * @block_count: The size of the file in 512-byte blocks (a
#GnomeVFSFileSize),

-> I may be totally wrong here, but isn't this filesystem dependant?

kr,

On Sun, 18 Jun 2006, Christian Neumair wrote:

I've spent some more hours on GnomeVFS docs and the Xfer docs should be
in a way better shape now. I got commit permission for the last one
already, but this one is significantly larger (240 kB, but including the
tmpl/ regeneration garbage).

Chipzz AKA
Jan Van Buggenhout
--

------------------------------------------------------------------------
                 UNIX isn't dead - It just smells funny
                           Chipzz ULYSSIS Org
------------------------------------------------------------------------
"Baldric, you wouldn't recognize a subtle plan if it painted itself pur-
 ple and danced naked on a harpsicord singing 'subtle plans are here a-
 gain'."



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]