Re: [PATCH] Properly handle GNOME_VFS_XFER_OVERWRITE_MODE_ABORT in xfer operation



On Thu, 2006-01-26 at 23:28 +0100, Martin Wehner wrote:
> On Sun, 2006-01-15 at 13:27 +0100, Christian Neumair wrote: 
> > Am Donnerstag, den 12.01.2006, 13:09 +0100 schrieb Alexander Larsson:
> > > On Wed, 2006-01-11 at 21:38 +0100, Christian Neumair wrote:
> > > > The attached patch makes GnomeVFS set the vfs_error to
> > > > GNOME_VFS_ERROR_INTERRUPTED instead of GNOME_VFS_ERROR_FILE_EXISTS when
> > > > the operation was cancelled.
> > > 
> > > Looks good to commit.
> > 
> > Done.
> > 
> 
> That patch broke transfers with the USE_UNIQUE_NAMES flag to some
> extend. Please see bug 327984.

I reverted this for now to avoid the regression. An unnecessary warning
dialog is clearly better than broken functionallity.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a sword-wielding coffee-fuelled assassin on the run. She's a man-hating 
hypochondriac college professor with a song in her heart and a spring in her 
step. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]